-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat(ingest): add structured log category #14229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
metadata-ingestion/src/datahub/ingestion/source/fivetran/fivetran.py
Outdated
Show resolved
Hide resolved
gabe-lyons
reviewed
Jul 30, 2025
@@ -231,9 +257,19 @@ def warning( | |||
title: Optional[LiteralString] = None, | |||
exc: Optional[BaseException] = None, | |||
log: bool = True, | |||
log_type: Optional[StructuredLogType] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets rename to log_category, since type would make me think that it would be warn/error/etc
gabe-lyons
reviewed
Jul 30, 2025
gabe-lyons
reviewed
Jul 30, 2025
8c84882
to
5e4cc41
Compare
gabe-lyons
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is that sometimes our log messages are not helpful for self-serve. Adding a type to the message tells everyone that it is related to
LINEAGE
. We can decide on more types in the future and slowly add thislog_type
in our logging so it is easier to self-serve understand the impact of various logs. This should be driven by where folks are unable to self-serve using our log messages.Just added in mock data source for now to show + Fivetran where I recently faced this so I know it affects lineage.
It shows in logs like this